Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean up fontsource guide #2514

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

ayuhito
Copy link
Contributor

@ayuhito ayuhito commented Apr 17, 2024

📝 Description

This cleans up the Fontsource guide a little and fixes the incorrect examples. Additionally, I recommend pushing developers to use variable fonts for more flexibility (and slowly educate it to new developers as the new norm which is also what Google Fonts is doing).

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

I also maintain Fontsource and was wondering if you wanted to remove the Chakra UI guide from the sidebar and want to replace that with PandaCSS? If I understand correctly, Chakra UI is no longer the focus, right? I can make that change for you if that is ideal.

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: b1a3fb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-playground ✅ Ready (Inspect) Visit Preview Apr 17, 2024 6:20pm
panda-studio ✅ Ready (Inspect) Visit Preview Apr 17, 2024 6:20pm

Copy link

vercel bot commented Apr 17, 2024

@ayuhito is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@segunadebayo
Copy link
Member

Thanks for this PR, @ayuhito

Chakra UI is still in focus, and we'll launch v3 shortly. We don't intend to replace Chakra UI with Panda in your guide; instead we would love to have an additional guide for Panda in your docs.

@segunadebayo segunadebayo merged commit 4222165 into chakra-ui:main Apr 17, 2024
2 of 3 checks passed
@ayuhito ayuhito deleted the docs/fontsource branch April 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants