Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inline @box-extractor/core as @pandacss/extractor #387

Merged
merged 50 commits into from
Apr 11, 2023
Merged

feat: inline @box-extractor/core as @pandacss/extractor #387

merged 50 commits into from
Apr 11, 2023

Conversation

astahmer
Copy link
Collaborator

  • I basically copy/pasted the files from this folder
  • also inlined the @box-extractor/logger, you might want to change that ? not sure, this is why I haven't touched it yet, some features are cool tho (compatible with DEBUG, has colors & ms diffs while being less bloated, can show where it was called with DEBUG_STACK, and has convenient methods like .scoped/ .lazy / etc, your call tho)
  • removed a file findAllTransitiveComponents, which won't be of any use here I think (some others are currently of no use as well such as extractAtRange etc but I think they could be at some point)
  • inlined isObject/isObjectLiteral imports from pastable (a personal utils lib) to remove a dependency that is not worth it here
  • removed some // eslint-disable that were not enabled on panda
  • removed some superfluous tests, updated the snapshots without the custom serializer that I had in the original repo, which impacts Set/Map and BoxNode and was called on any array/objects, it also used to prettify (with prettier), so this is why there's so much diffs in whitespace etc
  • add 2 latests versions of @box-extractor/core to the versions benchmark
  • finally, swap dependency in @pandacss/parser & @pandacss/types from @box-extractor/core to @pandacss/extractor

other than the changes listed above, I haven't touched at anything in the extractor src

@astahmer
feat(extractor): init package from @box-extractor/core + @box-extract…
73065f0 
…or/logger (inlined)

chore: format with prettier

rm findAllTransitiveComponents which won't be of any use here
inline isObject/isObjectLiteral imports from pastable to remove a dependency
@astahmer
test: update snapshots
6954ac5 
- remove some superfluous tests
- remove maybePretty / prettier formating on snapshots
- remove custom serializer (impacts Set/Map & used to call maybePretty)
@astahmer
feat: add 2 latests versions of @box-extractor/core to the bench
de83b95
@astahmer
refactor: swap dependency from @box-extractor/core to @pandacss/extra…
c24af5b 
…ctor
@astahmer
test: update snapshots after dep swap
d180c9b
@vercel
Copy link

vercel bot commented Mar 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-app ✅ Ready (Inspect) Visit Preview Apr 11, 2023 5:41pm
panda-playground ✅ Ready (Inspect) Visit Preview Apr 11, 2023 5:41pm

@segunadebayo segunadebayo merged commit 78f6012 into main Apr 11, 2023
@segunadebayo segunadebayo deleted the feat/inline-box-extractor branch April 11, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segunadebayo segunadebayo segunadebayo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@astahmer @segunadebayo