Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css-var): make cssVar be able to handle slash as token name (#983) #997

Conversation

custardcream98
Copy link
Contributor

@custardcream98 custardcream98 commented Jul 9, 2023

Closes #983

📝 Description

  • The / character has been added to the escRegex in css-var.ts to enable handling token names with slashes.
  • A test case for special characters has been added.

⛳️ Current behavior (updates)

Currently, it is not possible to use a slash (/) as a token name.

🚀 New behavior

With this pull request, it becomes possible to use a slash (/) as a token name.

💣 Is this a breaking change (Yes/No):

Nope

📝 Additional Information

As mentioned in the documentation, tokens should be used with the token() function.

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2023

🦋 Changeset detected

Latest commit: 85afe09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@pandacss/shared Patch
@pandacss/dev Patch
@pandacss/core Patch
@pandacss/generator Patch
@pandacss/node Patch
@pandacss/parser Patch
@pandacss/studio Patch
@pandacss/token-dictionary Patch
@pandacss/language-server Patch
@pandacss/extension-shared Patch
panda-css-vscode Patch
@pandacss/postcss Patch
@pandacss/types Patch
@pandacss/ts-plugin Patch
@pandacss/astro Patch
@pandacss/config Patch
@pandacss/error Patch
@pandacss/extractor Patch
@pandacss/fixture Patch
@pandacss/is-valid-prop Patch
@pandacss/logger Patch
@pandacss/preset-atlaskit Patch
@pandacss/preset-base Patch
@pandacss/preset-panda Patch
@pandacss/vsix-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Jul 9, 2023 7:35pm
panda-playground ✅ Ready (Inspect) Visit Preview Jul 9, 2023 7:35pm
panda-studio ✅ Ready (Inspect) Visit Preview Jul 9, 2023 7:35pm

@custardcream98 custardcream98 force-pushed the feature/use-slash-for-token-names branch from 064b67b to 85afe09 Compare July 9, 2023 19:29
@segunadebayo segunadebayo changed the title feat(css-var): make cssVar be able to handle slash as token name (#983) fix(css-var): make cssVar be able to handle slash as token name (#983) Jul 9, 2023
@segunadebayo segunadebayo merged commit f59154f into chakra-ui:main Jul 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use slash (/) for token names
2 participants