Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing regex to match only first #23

Closed
ZSkycat opened this issue Jul 6, 2018 · 2 comments
Closed

Allowing regex to match only first #23

ZSkycat opened this issue Jul 6, 2018 · 2 comments
Labels
enhancement help wanted

Comments

@ZSkycat
Copy link
Contributor

ZSkycat commented Jul 6, 2018

When I only need to find the first one, I don't need g flag.

scenes to be used: https://github.com/ZSkycat/ghost-progress-webpack-plugin/blob/master/src/helper.ts#L80
ZSkycat added a commit to ZSkycat/ansi-regex that referenced this issue Jul 6, 2018
@ZSkycat
Allowing regex patterns to specify flags (chalk#23)
045bf59 
chalk#23
@sindresorhus
Copy link
Member

Sounds like a valid use-case. I don't think it should accept regex flags though, but rather an option called onlyFirst to match only the first item.

@ZSkycat
Copy link
Contributor Author

ZSkycat commented Jul 6, 2018

Agree, I will modify my commit

@ZSkycat ZSkycat changed the title Allowing regex patterns to specify flags Allowing regex to match only first Jul 6, 2018
ZSkycat pushed a commit to ZSkycat/ansi-regex that referenced this issue Jul 6, 2018
Allowing regex to match only first (chalk#23)
44f0214
ZSkycat added a commit to ZSkycat/ansi-regex that referenced this issue Jul 6, 2018
@ZSkycat
Allowing regex to match only first (chalk#23)
f1bf82f
@ZSkycat ZSkycat mentioned this issue Jul 6, 2018
Merged
sindresorhus pushed a commit that referenced this issue Sep 18, 2018
@ZSkycat @sindresorhus
Add option to only match the first occurrence (#24)
eac826a 
Fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @ZSkycat