Add --demo flag
#10
Add --demo flag
#10
Conversation
cli.js
Outdated
|
|
||
| Examples | ||
| $ chalk --demo |
cli.js
Outdated
| @@ -12,9 +12,11 @@ const cli = meow(` | |||
| $ echo <string> | chalk <style> … | |||
|
|
|||
| Options | |||
| --template, -t Style template. The \`~\` character negates the style. | |||
| --template, -t Style template. The \`~\` character negates the style. | |||
| --demo, -d Demo of chalk possibilities. | |||
There was a problem hiding this comment.
Needs a better description. And no point in having a short flag for this.
There was a problem hiding this comment.
The help output needs to be updated in the readme too.
There was a problem hiding this comment.
What do you want as a description then, would be easier than trying to figure it out :)
I'll push the corrections once we decide the right description.
cli.js
Outdated
| chalk.bgBlue('bgBlue'), | ||
| chalk.bgMagenta('bgMagenta'), | ||
| chalk.bgCyan('bgCyan'), | ||
| chalk.bgWhite('bgWhite') |
There was a problem hiding this comment.
This can be simplified by putting the names in an array, looping over it and calling the chalk method by that name.
cli.js
Outdated
| @@ -42,7 +48,34 @@ function init(data) { | |||
| } | |||
|
|
|||
| if (process.stdin.isTTY || cli.flags.stdin === false) { | |||
| if (cli.flags.template) { | |||
| if (cli.flags.demo) { | |||
| const demoStr = [ | |||
cli.js
Outdated
| @@ -42,7 +48,34 @@ function init(data) { | |||
| } | |||
|
|
|||
| if (process.stdin.isTTY || cli.flags.stdin === false) { | |||
| if (cli.flags.template) { | |||
| if (cli.flags.demo) { | |||
| const demoStr = [ | |||
There was a problem hiding this comment.
The whole demo thing should be moved to a top-level function and just called here.
cli.js
Outdated
| @@ -6,15 +6,22 @@ const dotProp = require('dot-prop'); | |||
| const getStdin = require('get-stdin'); | |||
| const meow = require('meow'); | |||
|
|
|||
| function demoFunction() { | |||
| const demoString = ['bold', 'dim', 'italic', 'underline', 'inverse', 'strikethrough', 'black', 'red', 'green', 'yellow', 'blue', 'magenta', 'cyan', 'white', 'gray', 'bgBlack', 'bgRed', 'bgGreen', 'bgYellow', 'bgBlue', 'bgMagenta', 'bgCyan', 'bgWhite']; | |||
There was a problem hiding this comment.
Put each item on a separate line.
cli.js
Outdated
| const cli = meow(` | ||
| Usage | ||
| $ chalk <style> … <string> | ||
| $ echo <string> | chalk <style> … | ||
|
|
||
| Options | ||
| --template, -t Style template. The \`~\` character negates the style. | ||
| --template, -t Style template. The \`~\` character negates the style. | ||
| --demo Demo of all Chalk styles. |
There was a problem hiding this comment.
The descriptions should be vertically aligned.
cli.js
Outdated
|
|
||
| Examples | ||
| $ chalk --demo |
There was a problem hiding this comment.
Don't need an example of this.
readme.md
Outdated
| @@ -23,6 +23,7 @@ $ chalk --help | |||
|
|
|||
| Options | |||
| --template, -t Style template. The `~` character negates the style. | |||
| --demo Demo of all Chalk styles. | |||
There was a problem hiding this comment.
Incorrect indentation still
wcastand
force-pushed
the
demo-options
branch
from
1948da3
to
22981d4
Compare
|
Sorry for the indentation problems, mix of tab and space i didn't noticed. |
|
Thanks :) |
Do we need a test for it ? i started doing it but feels dumb so i didn't keep it lol
Tell me if anything is not ok :)
Fixes chalk/chalk#210