Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript type definition #148

Closed
Jameskmonger opened this issue Apr 28, 2017 · 14 comments
Closed

TypeScript type definition #148

Jameskmonger opened this issue Apr 28, 2017 · 14 comments

Comments

@Jameskmonger
Copy link

It would be good to have the typings for chalk distributed with the npm package:

  • Easier to use with TypeScript (no external dependencies needed)
  • Easier to ensure that the typings are in sync with the library
  • Easier for users to be more confident that the typings are in sync
@sindresorhus
Copy link
Member

I usually don't do this, for reasons outlined in sindresorhus/ama#439, but since Chalk is one of the most popular packages on npm, I'm gonna accept it if you or someone else can commit to maintain it.

@corbin-r
Copy link

Since I write quite a bit of TypeScript, I could write a typing for Chalk and maintain it... That wouldn't be an issue.

@sindresorhus
Copy link
Member

@basedjux That would be awesome. Pull request welcome :)

@corbin-r
Copy link

@sindresorhus cool!
I'll get working on that 😄

@corbin-r
Copy link

Never mind @sindresorhus, looks like someone beat me to it writing a definition:
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/chalk

@sindresorhus
Copy link
Member

That one is very outdated.

@corbin-r
Copy link

Ah yeah it is, 3 months.
Okay I'll write the updated one.

@sindresorhus
Copy link
Member

It's based on a more than 2 year old Chalk version.

@corbin-r
Copy link

Yeesh yeah that's scary outdated.

@Jameskmonger
Copy link
Author

@basedjux @sindresorhus Is this going to be distributed with the npm package? I think that's the best way to create a seamless experience.

@sindresorhus
Copy link
Member

Yes

@Qix-
Copy link
Member

Qix- commented Jun 30, 2017

@basedjux We just bumped to v2 by the way :)

@corbin-r
Copy link

@Qix- Yeah, I saw the tweet!
I'll be looking at those API changes.

@sindresorhus sindresorhus changed the title Distribute TypeScript typings TypeScript type definition Jun 30, 2017
@sindresorhus
Copy link
Member

This was added in v2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants