-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Windows) Consider using standard color scheme when term is xterm like #59
Comments
@weikinhuang Why current version doesn't meet your requirements? Current / expected screenshot is very welcome. |
Sure thing, here's the screenshot (using SecureCRT, with xterm-256 emulator mode): "use strict";
const chalk = require("chalk");
[ "black", "red", "green", "yellow", "blue", "magenta", "cyan", "white", "gray" ].forEach(function(color) {
process.stdout.write(chalk[color](color) + " ");
});
process.stdout.write("\n");
[ "bgBlack", "bgRed", "bgGreen", "bgYellow", "bgBlue", "bgMagenta", "bgCyan", "bgWhite" ].forEach(function(color) {
process.stdout.write(chalk[color](color) + " ");
});
process.stdout.write("\n"); |
I say again:
The screenshot looks good to me. |
Ah, OK. You meant that chalk should disable these lines on the terminals with solarized color theme? |
Ya, but not necessarily with a solarized theme, but terminals that supports proper colors. |
Can you send a PR? |
PR sent, I couldn't decide if I should test against |
perhaps check for:
process.platform === 'win32' && !process.env.TERM
or
process.platform === 'win32' && !(/xterm/).test(process.env.TERM || "")
I am suggesting this because I use node through a solarized color shell (admittedly through cygwin ssh).
Thanks.
The text was updated successfully, but these errors were encountered: