Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage example in the readme #251

Merged
merged 2 commits into from
Feb 11, 2018
Merged

Fix usage example in the readme #251

merged 2 commits into from
Feb 11, 2018

Conversation

apsknight
Copy link
Contributor

This PR fixes #250

Thanks!

ghost
ghost approved these changes Feb 5, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but is never mentioned that the result would be Hello World and not HelloWorld

@apsknight
Copy link
Contributor Author

But isn't it better to have Hello World than HelloWorld.

@ghost
Copy link

ghost commented Feb 6, 2018

Yeah!

@sindresorhus sindresorhus changed the title Add Space in Hello World statement Fix usage example in the readme Feb 11, 2018
@sindresorhus sindresorhus merged commit 011dd04 into chalk:master Feb 11, 2018
@sindresorhus
Copy link
Member

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation Fix
2 participants
@apsknight @sindresorhus