-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type definitions badge #286
Conversation
Is there any way to get the badge without the version numbers? The badge is very long and I don't see much value in having those version numbers. |
It is really long. The reason I had included the version numbers was to help developers distinguish between well maintained libraries, whose defs are being kept up to date, and libraries which aren't. It seems like the version number is useful for that. That said, I'm relatively new to TypeScript and Flow so I appreciate your perspective on this! Further thoughts? |
What if my library is mature and stable and doesn't need updates? Many packages don't even have TS or Flow as development dependencies. I would go for number 2. |
I see. Thanks. 👍 Could I ask a couple other questions? For packages that don’t declare the dependencies, is there a better way to infer their type support? Is it possible that a future breaking change to the language would require definitions to be updated, even if the library is mature? |
For TS, you could look for a For Flow, you could look for a
Yes, but I don't think a version is a good enough indicator of that. TS might break a library in a minor release or never. It really depends on what features you use and how. For simple node modules, it's unlikely new versions will break much. |
Great. Thanks so much for the feedback. Give me a few days and I will make some updates to the badge. |
Based on feedback at chalk/chalk#286.
@paulmelnikow Can this be finished now? |
Late to the game but 2 was the choice I would have made as well. Just for some validation 💃 |
We can drop the Awesome badge. |
SGTM, thanks @sindresorhus and @paulmelnikow! |
Ah yep! Thanks for merging this! |
Hi @sindresorhus! I added this badge to Shields at your suggestion badges/shields#1252, and though I'd see if you'd like to include it here!