Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on escape-string-regexp #304

Closed
wants to merge 3 commits into from
Closed

Remove dependency on escape-string-regexp #304

wants to merge 3 commits into from

Conversation

Chalarangelo
Copy link

As chalk is used by thousands of people daily and provided that escape-string-regexp is a very simple package, I went ahead and removed the extra dependency from package.json, replacing it with an inline function. Feel free to close, if you believe this could introduce problems down the line, as it is an opinionated change.

@sindresorhus
Copy link
Member

No thanks, but you should take a look at #300 where I propose a better solution ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants