Export Color type #336
Closed
Export Color type #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, but I think we should split it in |
|
@natealcedo ping 🙂 |
|
Hello again! Sorry I neglected this. Thanks @SimenB for reminding me. Let me take a look at this again over the weekend :) |
|
Hi actually, I've been terribly busy with work and my personal life. I'm not sure if I can pick this up anytime soon if anyone wants to take a stab at this. :) |
|
Opened up #357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR exposes a type for colors supported by chalk. The use case of this is so that consumers of this library can programatically check if a color is available.
One example is in this PR. jestjs/jest#8025
I am hardcoding the possible values that a color can be. https://github.com/facebook/jest/pull/8025/files#diff-6170a10d44dcb3222b64fba6427d69c7R234