Export styles from ansi-styles

[LitoMore]

ansi-styles adds some extra keys to styles:

chalk/source/vendor/ansi-styles/index.js

Lines 98 to 103 in 92c55db

	styles.color.ansi = wrapAnsi16();
	styles.color.ansi256 = wrapAnsi256();
	styles.color.ansi16m = wrapAnsi16m();
	styles.bgColor.ansi = wrapAnsi16(ANSI_BACKGROUND_OFFSET);
	styles.bgColor.ansi256 = wrapAnsi256(ANSI_BACKGROUND_OFFSET);
	styles.bgColor.ansi16m = wrapAnsi16m(ANSI_BACKGROUND_OFFSET);

We should filter them out.

Or we could process those style names in ansi-sytle, see chalk/ansi-styles#82. I marked that PR as a draft to discuss how we can improve on this.

My thoughts are:

Option 1:
Filter style names in Chalk

Option 2:
Apply chalk/ansi-styles#82, then export style names from ansi-styles in Chalk

Option 3:
Apply chalk/ansi-styles#82 change but in favor of modify the vendor/ansi-styles directly, then export styles names

What do you think?

For the exposed style names, we'd better add some tests to ensure its outputs are correct.

[sindresorhus]

I would go with option 2.

Option 3 is not entirely clear to me.

[LitoMore]

Option 3 is not entirely clear to me.

I mean change the code directly in https://github.com/chalk/chalk/blob/main/source/vendor/ansi-styles/index.js. But I don't think it's a good solution.

[sindresorhus]

I mean change the code directly in https://github.com/chalk/chalk/blob/main/source/vendor/ansi-styles/index.js. But I don't think it's a good solution.

No, we shouldn't do that. The vendor stuff is meant to be kept in sync with the source.

[LitoMore]

Of course. I marked the chalk/ansi-styles#82 as ready, please review.

I will sync those changes to this project.

[codecov]

Codecov Report

Merging #567 (5a3245c) into main (92c55db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   99.60%   99.61%           
=======================================
  Files           8        8           
  Lines         509      517    +8     
=======================================
+ Hits          507      515    +8     
  Misses          2        2           

Impacted Files	Coverage Δ
source/index.js	99.11% <100.00%> (+0.03%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sindresorhus]

Can you change the exports to use the Name suffix like ansi-styles? We already shipped the current names, so we need to preserve those using an alias with a @deprecated doc comment.

[LitoMore]

@sindresorhus Done. This failing CI doesn't seem to be related to the code.

[Qix-]

https://github.com/chalk/chalk/blob/main/.github/workflows/main.yml#L25

Not sure the goal here with this check but seems like codecov is completely broken regardless of version, it's just that it's only enabled on 16.

[LitoMore]

Passing now.

[Qix-]

Curious, what was the issue? The error message led me to believe it was a transient issue...

[LitoMore]

No idea. I just git commit --amend my commit. I believe it's a Codecov-related issue. Maybe they fixed the problem in a short time.