Export createSupportsColor function from supports-color
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 8 8
Lines 517 518 +1
=======================================
+ Hits 515 516 +1
Misses 2 2
|
|
@lukekarrys what is your use/what would be gained and what's the drawback? I'd guess 100 bytes...? |
|
I hadn't even thought of the bytes. I see pros/cons for merging this as: Cons:
Pros:
This is a very trivial change, and I don't mind if it's not merged. It would get used in my project, but I'm also fine using |
|
Seems like a good contribution hope author replies and accepts it
…On Wed, 8 Nov 2023 at 18:34, Luke Karrys ***@***.***> wrote:
I hadn't even thought of the bytes. I see pros/cons for merging this as:
Cons:
- Maintenance burden, including needing to figure out semver for chalk
if supports-color has breaking changes
Pros:
- Users only need to install and keep up to date 1 package
- Guarantee that version of supports-color is the same between chalk
and one consumed by user
This is a very trivial change, and I don't mind if it's not merged. It
would get used in my project, but I'm also fine using supports-color as
well.
—
Reply to this email directly, view it on GitHub
<#600 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQBYVOGLGB6AIY7VLMPJWVTYDP3FPAVCNFSM6AAAAAAZF5FCW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSG4YTKNRQGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use for this function when using
chalk. It would be nice if I could grab this function without needing to installsupports-color, especially since it is vendored bychalk.Edit: this also updates
xoto the latest version to fix a crash when linting. Tests should hopefully pass on this PR now.