tweak defining proto

[stevemao]

No description provided.

[sindresorhus]

Don't do unrelated changes. Bumping deps should be a separate PR.

[sindresorhus]

The description field is there for a reason ;) Could you describe what you've changed and why?

[Qix-]

All this PR seems to do is to remove the function that generates the Chalk prototype in lieu of a simple object. There are reasons why we do this. Could you explain the decision behind changing this?

[jbnicolai]

The proposed implementation is simpler, and has less code.. so I'm all for 😉

@Qix- what's the reason? I suspect it's an artifact of refactor-fu back when trying to make the whole chained-call implementation performant, but perhaps I'm unaware of the slight difference between the current implementation's behaviour and that of the PR.

All tests seem to pass though, and running the benchmark 10 times on both reveals no difference in performance.

for i in {0..10}; do npm run bench; done | grep Elapsed

on master:

  Elapsed: 5,773.57 ms
  Elapsed: 5,819.39 ms
  Elapsed: 5,974.76 ms
  Elapsed: 5,678.02 ms
  Elapsed: 5,809.12 ms
  Elapsed: 5,790.01 ms
  Elapsed: 5,809.15 ms
  Elapsed: 5,724.53 ms
  Elapsed: 5,870.90 ms
  Elapsed: 5,789.78 ms
  Elapsed: 5,970.74 ms

on stevemao/cleanup:

  Elapsed: 5,770.72 ms
  Elapsed: 5,770.93 ms
  Elapsed: 5,917.21 ms
  Elapsed: 5,872.29 ms
  Elapsed: 5,757.63 ms
  Elapsed: 5,804.15 ms
  Elapsed: 5,733.41 ms
  Elapsed: 5,950.70 ms
  Elapsed: 5,967.84 ms
  Elapsed: 5,961.10 ms
  Elapsed: 5,798.23 ms

[stevemao]

This is to just make the code simpler. and the logic is pretty much the same as generating the styles above so I'm reusing it.

[stevemao]

I'll make the changes tonight :)

[stevemao]

I broke this into three PRs (#96, #97)

[stevemao]

Any questions/problems with this PR?

[sindresorhus]

I'm busy at the moment, will try to review in a few days.

@jbnicolai @Qix- Looks good to you?

[Qix-]

Yeah this looks fine. I misread what happened with the removal of the function.

[sindresorhus]

@stevemao Awesome! Thank you. I dig PRs that simplify the code :)