Target Node.js 18, update dependencies #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy-mitchell
commented
Jan 27, 2024
Comment on lines
+18
to
+23
| const error = await t.throwsAsync(execa('./cli.js', {stdin: 'inherit'})); | ||
|
|
||
| t.like(error, { | ||
| stderr: 'Input required', | ||
| exitCode: 1, | ||
| }); |
There was a problem hiding this comment.
...yeah, I guess it makes sense that the action runner's shell isn't TTY lol
Does execa have a way to simulate it?
There was a problem hiding this comment.
No, but you can force Chalk to use colors even when not interactive using an environment variable.
There was a problem hiding this comment.
Lines 24 to 27 in 5ed811e
It’s for this check, I’m not sure if that would help.
There was a problem hiding this comment.
Ah, ok. You could use a PTY, but not worth the effort. Just skip that test.
There was a problem hiding this comment.
So this workaround worked: tommy-mitchell@a8bb159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
strip-ansiv7.1.0)