Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: addressing some unanticipated situations #142

Merged
merged 10 commits into from Dec 7, 2022
Merged

fix: addressing some unanticipated situations #142

merged 10 commits into from Dec 7, 2022

Conversation

idranme
Copy link
Contributor

@idranme idranme commented Nov 28, 2022

Avoid requesting unnecessary permissions when used by Deno users.
Modern Chromium supports true color.

@idranme idranme mentioned this pull request Nov 28, 2022
Closed
@idranme
Copy link
Contributor Author

idranme commented Dec 4, 2022

PTAL @sindresorhus

@sindresorhus
Copy link
Member

CI is failing and this PR needs a proper title.

@idranme
Copy link
Contributor Author

idranme commented Dec 4, 2022

CI is failing and this PR needs a proper title.

Okay, I'll try to modify.

@idranme idranme changed the title fix fix: addressing some unanticipated situations Dec 4, 2022
@idranme
Copy link
Contributor Author

idranme commented Dec 4, 2022

CI is failing and this PR needs a proper title.

done

sindresorhus
sindresorhus reviewed Dec 4, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Dec 4, 2022
View reviewed changes
browser.js Outdated Show resolved Hide resolved
@idranme @sindresorhus
Update browser.js
6d0ac31 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Qix-
Qix- requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@Qix- Qix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not particularly fond of these changes but with the requested change it isn't the worst I suppose.

Maybe I'm missing something (your PR doesn't explain what these changes actually do...) but what are the changes in the browser implementation trying to achieve?

browser.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@idranme
Copy link
Contributor Author

idranme commented Dec 5, 2022

I'm not particularly fond of these changes but with the requested change it isn't the worst I suppose.

Maybe I'm missing something (your PR doesn't explain what these changes actually do...) but what are the changes in the browser implementation trying to achieve?

Starting with the specified version, Chromium's console can output true color.

@idranme idranme requested review from Qix- and removed request for sindresorhus December 5, 2022 16:51
Qix-
Qix- approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@Qix- Qix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look better.

sindresorhus
sindresorhus reviewed Dec 6, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
@idranme @sindresorhus
Update index.js
81074b4 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus sindresorhus merged commit b3d6534 into chalk:main Dec 7, 2022
@sindresorhus
Copy link
Member

@idanran Can you submit these changes to Chalk too? Which bundles this package.

@idranme
Copy link
Contributor Author

idranme commented Dec 7, 2022

@idanran Can you submit these changes to Chalk too? Which bundles this package.

No problem.

@idranme idranme mentioned this pull request Dec 7, 2022
Merged
@tryptophane tryptophane mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qix- Qix- Qix- approved these changes

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@idranme @sindresorhus @Qix- @idanran