Handle spaces inside background color escapes #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.
The original issue is about
wrap-ansi
stripping the beginning space, if string is wrapped into an ansi escape (usually colors). I think it's ok forchalk.green(' hello ')
, because spaces won't be colorized anyway. However, forchalk.bgGreen(' hello ')
this results in:Reason it was happening is because
wrap-ansi
splits input string by space here https://github.com/chalk/wrap-ansi/blob/master/index.js#L82.This PR fixes this case by scanning result of
split()
and joining opening escape, content and closing escape (following is pseudo code).This PR is still failing, because it doesn't yet handle
chalk.bgGreen(' hello ' + chalk.red('world'))
case. Any help is appreciated!