Support hyperlinks in supported terminals #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apped links with the appropriate ansi escape to shorten the output and not hyperlink multiple times per wrapped word
|
// @stroncium @TiagoDanin Would you be able to help review? |
stroncium
reviewed
Oct 21, 2019
stroncium
reviewed
Oct 22, 2019
|
@nicholaschiasson Ping :) |
|
Just updating, I plan to resolve all of the open discussions here soon! Sorry for the wait 😄 |
Fixed hyperlink wrap by adding the hyperlink ansi wrap opening and closing on each beginning and ending of line, respectively, where necessary. Fixed existing bug where the string 'pre' was being incorrectly indexed without considering surrogate pairs, instead deconstructed it into an array. Added test case to cover code paths where an ansi escape is used which does not match on Select Graphic Rendition or ansi hyperlink patterns. Made hyperlink test cases much more understandable.
…n supportive terminals
|
Addressed all discussions, but apparently support for node 8 is broken. I will look into this soon. |
|
Support for Node.js 8 doesn’t matter. I plan to target Node.js 10 after this PR. |
Ah whoops, I fixed it nonetheless. Up to you which style is preferable, named regex capture groups or not, but in any case I think this is ready again for review. |
|
Can you revert 2b6a0b4? |
sindresorhus
changed the title
This reverts commit 2b6a0b4.
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor