Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChameleonPluginBootstrap to allow users to provide custom plugin creation logic #259

Closed
1 task done
joshuasing opened this issue Aug 31, 2023 · 0 comments · Fixed by #265
Closed
1 task done
Labels
area: platform This involves updating, adding or removing a platform type: enhancement This is a feature request or a pull request that adds a feature type: feature This adds a new feature

Comments

@joshuasing
Copy link
Member

Confirmation

  • I have checked for similar issues.

Problem

Chameleon currently creates a new instance of the ChameleonPlugin class via reflection.
This does not allow for any custom creation logic, and could cause instantiation issues to go undetected until runtime.

Suggested solution

We could add a ChameleonPluginBootstrap interface that could be used instead of providing a ChameleonPlugin class.
Paper provides a similar functionality: https://docs.papermc.io/paper/dev/getting-started/paper-plugins#bootstrapper

Additional information

No response

@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature status: future This might be done in the future contributor: wanted area: platform This involves updating, adding or removing a platform type: feature This adds a new feature and removed status: future This might be done in the future contributor: wanted labels Aug 31, 2023
@joshuasing joshuasing linked a pull request Aug 31, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: platform This involves updating, adding or removing a platform type: enhancement This is a feature request or a pull request that adds a feature type: feature This adds a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant