Added method so that a channel does not have to be provided #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @genebean You added a route which does almost exactly the same as the existing one. The only difference is the channel name resolution, so please update to only have one function which is called by both routes |
|
I was wondering if that was what I should do or not... I am going to have to do a touch of reading first but am happy to adjust. Thanks for the feedback. |
|
How's this look @chamerling? |
|
Just wanted to follow up and see if more changes are needed. Thanks @chamerling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Slack webhooks are tied to a channel by default. Adding this method allows you to post to
/webhookand post to the channel the webhook is tied to.