Exercise: Fix notifications BT#17787

chamilo · Oct 28, 2020 · 773350d · 773350d
1 parent 73e53b6
commit 773350d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/main/exercise/exercise_result.php b/main/exercise/exercise_result.php
@@ -273,6 +273,12 @@
         MessageManager::send_message($currentUserId, $subject, $content);
     }
 
+    // Subject for notifications
+    $subject = sprintf(get_lang('WrongAttemptXInCourseX'), $attemptCountToSend, $courseInfo['title']);
+    if ($exercisePassed) {
+        $subject = sprintf(get_lang('ExerciseValidationInCourseX'), $courseInfo['title']);
+    }
+
     $extraFieldData = $exerciseExtraFieldValue->get_values_by_handler_and_field_variable(
         $objExercise->iId,
         'notifications'
@@ -362,7 +368,7 @@
                                 $objExercise->iId,
                                 $attempt['content']
                             );
-                            if ($extraFieldData && isset($extraFieldData['value'])) {
+                            if ($extraFieldData && isset($extraFieldData['value']) && !empty($extraFieldData['value'])) {
                                 $content = $extraFieldData['value'];
                             }
                         }