Improve password strength on registration form - refs BT#10269

chamilo · Sep 17, 2015 · c2320a5 · c2320a5
1 parent c505899
commit c2320a5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/main/admin/user_add.php b/main/admin/user_add.php
@@ -197,10 +197,15 @@ function display_drh_list(){
 );
 
 $form->addGroup($group, 'password', get_lang('Password'), '');
-$form->addGroupRule('password', 'password', 'required', null, 2);
+$form->addGroupRule('password', get_lang('EnterPassword'), 'required', null, 2);
 
 if ($checkPass) {
-    $form->addElement('label', null, '<div id="password_progress" style="display:none"></div>');
+    $passwordStrengthLabels = '
+        <div id="password-verdict"></div>
+        <div id="password-errors"></div>
+        <div id="password_progress" style="display:none"></div>
+    ';
+    $form->addElement('label', null, $passwordStrengthLabels);
 }
 
 // Status

diff --git a/main/inc/lib/api.lib.php b/main/inc/lib/api.lib.php
@@ -7234,8 +7234,8 @@ function api_get_password_checker_js($usernameInputId, $passwordInputid)
 
     var verdicts = ['".implode("','", $verdicts)."'];
     var errorMessages = {
-        password_to_short : '".get_lang('PasswordIsTooShort')."',
-        same_as_username : '".get_lang('YourPasswordCannotBeTheSameAsYourUsername')."'
+        password_to_short : \"" . get_lang('PasswordIsTooShort')."\",
+        same_as_username : \"".get_lang('YourPasswordCannotBeTheSameAsYourUsername')."\"
     };
 
     $(document).ready(function() {
@@ -7249,9 +7249,9 @@ function api_get_password_checker_js($usernameInputId, $passwordInputid)
             },
             errorMessages : errorMessages,
             viewports: {
-                progress: '#password_progress'
-                //verdict: undefined,
-                //errors: undefined
+                progress: '#password_progress',
+                verdict: '#password-verdict',
+                errors: '#password-errors'
             },
             usernameField: '$usernameInputId'
         };