Skip to content

Commit

Permalink
Fix UTC problem in session access dates for users - Refs #8143
Browse files Browse the repository at this point in the history
  • Loading branch information
@jloguercio
jloguercio committed Mar 22, 2016
1 parent 632c63e commit ca61bce
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions main/inc/lib/usermanager.lib.php
View file
Expand Up @@ -2455,10 +2455,10 @@ public static function get_sessions_by_category(
$categories[$row['session_category_id']]['sessions'][$row['id']] = array(
'session_name' => $row['name'],
'session_id' => $row['id'],
'access_start_date' => $row['access_start_date'],
'access_end_date' => $row['access_end_date'],
'coach_access_start_date' => $row['coach_access_start_date'],
'coach_access_end_date' => $row['coach_access_end_date'],
'access_start_date' => api_get_local_time($row['access_start_date']),
'access_end_date' => api_get_local_time($row['access_end_date']),
'coach_access_start_date' => api_get_local_time($row['coach_access_start_date']),
'coach_access_end_date' => api_get_local_time($row['coach_access_end_date']),
'courses' => $courseList
);
}
Expand Down

5 comments on commit ca61bce

@jmontoyaa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No me parece que es una buena idea hacer el cambio ahi.
Lo mejor sería ponerlo justamente antes que se vaya a mostrar.
Como esta función está dentro de usermanager.lib.php no se deberían de hacer cambios ahi.

O tal vez agregar algo asi:
access_start_date_local_time => api_get_local_time($row['access_start_date'])

@jmontoyaa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto no fue arreglado en su momento y ahora ocasiona un error en BT#11588

@ywarnier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmontoyaa Entendido. Llegaste a corregirlo de algun lado? De lo que puedo ver no está grabando esto en base de datos, así que el daño es reducido.

@jmontoyaa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relacionado: 048fbfd

@jmontoyaa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix 8a9b674

Please sign in to comment.