Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H5P plugin breaks jquery ui addons #4689

Closed
AngelFQC opened this issue Apr 25, 2023 · 3 comments
Closed

H5P plugin breaks jquery ui addons #4689

AngelFQC opened this issue Apr 25, 2023 · 3 comments
Labels
Milestone

Comments

@AngelFQC
Copy link
Member

The plugin re-adds the jquery-ui.min.js and this affects the other addons (datetimepicker, for example)

Chamilo already loads jquery-ui for all pages. So there should be no need to add it back.

Reference

$fh .= '<script type="text/javascript" src="'.$webPath.'web/assets/jquery-ui/jquery-ui.min.js"></script>';

@AngelFQC AngelFQC added the Bug label Apr 25, 2023
@AngelFQC AngelFQC added this to the 1.11.20 milestone Apr 25, 2023
@ywarnier
Copy link
Member

ywarnier commented May 4, 2023

@LudiscapeXApi

@LudiscapeXApi
Copy link
Contributor

This H5P engine is no longer valid, but here is a correction
$fh .= '<script>if (!jQuery.ui) {'; $fh .= "$('body').append('<script src=\"".$webPath."web/assets/jquery-ui/jquery-ui.min.js\"></script>');}</script>";
https://github.com/LudiscapeXApi/chamilo-lms/blob/patch-16-jqueryui/plugin/h5p/index.php

@ywarnier
Copy link
Member

ywarnier commented Jun 6, 2023

Seems fixed with the proposed patch. Sent here: 0ab027d
Thanks!
Closing.

@ywarnier ywarnier closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants