New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move methods to get user complete name to UserManager #2650
Conversation
Hide the username when showing the complete name for a user
The setting is not added in the Schema: "platform.hide_username_with_complete_name" It's not better to use the "Profile" Schema? src/CoreBundle/Settings/ProfileSettingsSchema.php |
@jmontoyaa Creo que está más relacionado con la plataforma en general que sólo con el perfil del usuario. |
Todo lo que va con el usuario debería estar en "Profile", ahí tenemos los settings globales relacionados al usuario (account_valid_duration, use_users_timezone, split_users_upload_directory, etc). No son necesariamente cosas de profile. Ponerlos en PlatformSettingsSchema es demasiado general. Hay que cambiar estos settings también:
Agregados aquí: Tal vez seria una buena idea de cambiar el nombre del archivo a UserSettingsSchema.php en lugar de |
Lint errors were found. A patch is also available. Please see the report: https://flintci.io/repositories/1013/analyses/10398 This comment was posted by FlintCI. It can be disabled in the repository settings. |
Moví los settings a ProfileSettingsSchema |
No description provided.