Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: fix performance problem when downloading a folder - refs CB#320326 #4084

Merged
merged 3 commits into from Apr 26, 2022

Conversation

renaudlemaire
Copy link

@ywarnier
Copy link
Member

Bonjour @renaudlemaire
Si tu pouvais faire les toutes petites corrections d'indentation demandées par Codacy dans l'onglet "Files changed", ce serait super (ça permettrait d'incorporer ton PR sans altération).

@renaudlemaire
Copy link
Author

Et voilà! (Autentica qualità)

@ywarnier
Copy link
Member

Et juste pour affiner encore un peu (et arriver à l'Autentica qualità), PHP CS (qu'on vient de configurer aujourd'hui hein, désolé) se plaint de ce que tu n'as pas respecté nos conventions en ne mettant pas d'espace autour du signe = aux lignes préfixées par - dans https://github.com/chamilo/chamilo-lms/runs/4365237395?check_suite_focus=true

@renaudlemaire
Copy link
Author

Corrigé.

@ywarnier ywarnier changed the title _#320326 : fixes performance problem when downloading a folder Document: fix performance problem when downloading a folder - refs CB#320326 Apr 26, 2022
@ywarnier ywarnier merged commit ed89f6e into chamilo:1.11.x Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants