Internal: Vue: Redirect to login form on PHP session expiration - refs BT#21825 #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelFQC
reviewed
Jul 3, 2024
| router.beforeEach(async (to, from, next) => { | ||
| if (to.matched.some(record => record.meta.requiresAuth)) { | ||
| try { | ||
| const response = await securityService.checkSession() |
There was a problem hiding this comment.
Con una instalación limpia, se hacen 2 llamadas a /check-session por página
Y después del login, se sigue viendo el form por un momento.
| if (to.matched.some(record => record.meta.requiresAuth)) { | ||
| try { | ||
| const response = await securityService.checkSession() | ||
| const isAuthenticated = response.isAuthenticated |
There was a problem hiding this comment.
Se tendría que actualizar también securityStore.isAuthenticated para mantener el estado en el store. Puede que eso sea el problema del login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.