Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRS fixes from 1.11.x #5629

Merged
merged 4 commits into from
Jul 4, 2024
Merged

LRS fixes from 1.11.x #5629

merged 4 commits into from
Jul 4, 2024

Conversation

AngelFQC
Copy link
Member

@AngelFQC AngelFQC commented Jul 3, 2024

See #3943

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 39.12%. Comparing base (11d197c) to head (8be4bfa).
Report is 9 commits behind head on master.

Files Patch % Lines
src/CoreBundle/Entity/XApiSharedStatement.php 0.00% 4 Missing ⚠️
src/CoreBundle/Entity/XApiVerb.php 0.00% 2 Missing ⚠️
...e/Migrations/Schema/V200/Version20240515094800.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5629      +/-   ##
============================================
- Coverage     39.13%   39.12%   -0.01%     
- Complexity    10961    10962       +1     
============================================
  Files           864      864              
  Lines         45332    45336       +4     
============================================
  Hits          17739    17739              
- Misses        27593    27597       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8007 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8031 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Jul 3, 2024

Code Climate has analyzed commit 8be4bfa and detected 341 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 286
Clarity 45
Complexity 4
Bug Risk 6

View more on Code Climate.

@ywarnier
Copy link
Member

ywarnier commented Jul 4, 2024

Not entirely reviewed but merging as we'll get time to review this in the following months and we need the database changes to close the alpha.

@ywarnier ywarnier merged commit 37aede9 into chamilo:master Jul 4, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants