Offhook / OnHook, not hanging up (force ast_hangup) #35

dkgroot · 2013-02-08T10:36:03Z

Reported by: Derek Ivy
Date: Fri - 8 Feb 2013
Mail: "Latest Trunk (4216) Broken with Asterisk 11"

You (Marcello) changed sccp_wrapper_asterisk_requestHangup
"sending hard hangup" section:
from
ast_hangup(ast_channel);
to
ast_queue_hangup(ast_channel);

Issue is fixed when moving back to ast_hangup(ast_channel).

For which issue did you replace the ast_hangup with ast_queue_hangup. Can we resolve this later issue in another way ? Could we use a sccp_wrapper_asterisk_forceHangup call at that location ?

marcelloceschia · 2013-02-08T11:02:47Z

Aber damit hast du die issues die Bob geschrieben hat!

dkgroot · 2013-02-08T11:11:45Z

In welcher mail von bob (sind immer 1000den vom ihm) [date/subject ?].

Was ist der losung.
ast_channel ohne ast_pbx sollte so weit ich weiss mit ein ast_hangup auf gehangt werden. Ist bei bob schon ein pbx gestarted ?

marcelloceschia · 2013-02-08T11:13:36Z

ja, siehe sein log

dkgroot · 2013-02-08T11:17:14Z

Du meinst das riesen ding ? Dadrauf hatt ich eigentlich keine lust.

Was war dein befund ? Von wo aus (im code) rust er den pbx(hangup) an ? Konnen wir da ein PBX(forceHangup)(queued) raus machen ?

Oder mussen wir die andere stelle, finden und anpassen (new call ohne nummer ein zu geben ->hangup. Weis nicht genau wie ich dies umschreiben soll) ?

dkgroot · 2013-02-09T13:08:04Z

Wurde dies das fixen ?

Added pbx_channel_pbx(ast_channel)

Diederik

Index: pbx_impl/ast/ast.c

--- pbx_impl/ast/ast.c (revision 4218)
+++ pbx_impl/ast/ast.c (working copy)
@@ -507,7 +507,7 @@
#else
pbx_channel_setwhentohangup_tv(ast_channel, ast_tvnow());
#endif
-// ast_channel->_state=AST_STATE_DOWN;
+// ast_channel->_state=AST_STATE_DOWN;
ast_queue_hangup(ast_channel);
break;
}
@@ -551,7 +551,7 @@
}
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send ast_softhangup_nolock (blocker: %s)\n", pbx_channel_name(ast_channel), pbx_channel_blockproc(ast_channel));
ast_softhangup_nolock(ast_channel, AST_SOFTHANGUP_DEV);

} else if (AST_STATE_UP == pbx_channel_state(ast_channel)) {
} else if (AST_STATE_UP == pbx_channel_state(ast_channel) || pbx_channel_pbx(ast_channel)) {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send ast_queue_hangup\n", pbx_channel_name(ast_channel));
#if ASTERISK_VERSION_NUMBER < 10601
pbx_channel_setwhentohangup_tv(ast_channel, 0);
@@ -561,8 +561,8 @@
ast_queue_hangup(ast_channel);
} else {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send hard ast_hangup\n", pbx_channel_name(ast_channel));
-// ast_hangup(ast_channel);
```
   ast_queue_hangup(ast_channel);
```
```
   ast_hangup(ast_channel);
```
+// ast_queue_hangup(ast_channel);
}

sccp_channel = sccp_channel ? sccp_channel_release(sccp_channel) : NULL;

Ooh das geht anscheinend nicht so gut mit ein diff !

marcelloceschia · 2013-02-09T13:12:02Z

probieren

Am Samstag, 9. Februar 2013, 05:08:04 schrieb Diederik de Groot:

Wurde dies das fixen ?

Added pbx_channel_pbx(ast_channel)

Diederik

Index: pbx_impl/ast/ast.c

--- pbx_impl/ast/ast.c (revision 4218)
+++ pbx_impl/ast/ast.c (working copy)
@@ -507,7 +507,7 @@
#else
pbx_channel_setwhentohangup_tv(ast_channel, ast_tvnow());
#endif
-// ast_channel->_state=AST_STATE_DOWN;
+// ast_channel->_state=AST_STATE_DOWN;
ast_queue_hangup(ast_channel);
break;
}
@@ -551,7 +551,7 @@
}
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send ast_softhangup_nolock (blocker: %s)\n", pbx_channel_name(ast_channel), pbx_channel_blockproc(ast_channel));
ast_softhangup_nolock(ast_channel, AST_SOFTHANGUP_DEV);
} else if (AST_STATE_UP == pbx_channel_state(ast_channel)) {

} else if (AST_STATE_UP == pbx_channel_state(ast_channel) || pbx_channel_pbx(ast_channel)) {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send ast_queue_hangup\n", pbx_channel_name(ast_channel));
#if ASTERISK_VERSION_NUMBER < 10601
pbx_channel_setwhentohangup_tv(ast_channel, 0);
@@ -561,8 +561,8 @@
ast_queue_hangup(ast_channel);
} else {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send hard ast_hangup\n", pbx_channel_name(ast_channel));
-// ast_hangup(ast_channel);
   ast_queue_hangup(ast_channel);
   ast_hangup(ast_channel);
+// ast_queue_hangup(ast_channel);
}

sccp_channel = sccp_channel ? sccp_channel_release(sccp_channel) : NULL;
Reply to this email directly or view it on GitHub:
#35 (comment)

dkgroot · 2013-02-09T14:17:52Z

Pickup / Hangup Funktioniert hier naturlich wieder normal.

Die frage ist, wie ich der andere situation nach stellen kann. Weist du
ganau wie ich/du das reproduzieren kannst ? Oder mussen wir dafur
leonid/bob fragen ?

Diederik

On 02/09/2013 02:12 PM, marcelloceschia wrote:

probieren

Am Samstag, 9. Februar 2013, 05:08:04 schrieb Diederik de Groot:

Wurde dies das fixen ?

Added pbx_channel_pbx(ast_channel)

Diederik

Index: pbx_impl/ast/ast.c

--- pbx_impl/ast/ast.c (revision 4218)
+++ pbx_impl/ast/ast.c (working copy)
@@ -507,7 +507,7 @@
#else
pbx_channel_setwhentohangup_tv(ast_channel, ast_tvnow());
#endif
-// ast_channel->_state=AST_STATE_DOWN;
+// ast_channel->_state=AST_STATE_DOWN;
ast_queue_hangup(ast_channel);
break;
}
@@ -551,7 +551,7 @@
}
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send
ast_softhangup_nolock (blocker: %s)\n", pbx_channel_name(ast_channel),
pbx_channel_blockproc(ast_channel));
ast_softhangup_nolock(ast_channel, AST_SOFTHANGUP_DEV);

} else if (AST_STATE_UP == pbx_channel_state(ast_channel)) {

} else if (AST_STATE_UP == pbx_channel_state(ast_channel) ||
pbx_channel_pbx(ast_channel)) {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send
ast_queue_hangup\n", pbx_channel_name(ast_channel));
#if ASTERISK_VERSION_NUMBER < 10601
pbx_channel_setwhentohangup_tv(ast_channel, 0);
@@ -561,8 +561,8 @@
ast_queue_hangup(ast_channel);
} else {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send hard
ast_hangup\n", pbx_channel_name(ast_channel));
-// ast_hangup(ast_channel);

ast_queue_hangup(ast_channel);

ast_hangup(ast_channel);
+// ast_queue_hangup(ast_channel);
}

sccp_channel = sccp_channel ? sccp_channel_release(sccp_channel) : NULL;

Reply to this email directly or view it on GitHub:

#35 (comment)

—
Reply to this email directly or view it on GitHub
#35 (comment)..

marcelloceschia · 2013-02-09T14:26:40Z

Am Samstag, 9. Februar 2013, 06:17:53 schrieb Diederik de Groot:

Pickup / Hangup Funktioniert hier naturlich wieder normal.

Die frage ist, wie ich der andere situation nach stellen kann. Weist du
ganau wie ich/du das reproduzieren kannst ? Oder mussen wir dafur
leonid/bob fragen ?

nee, weiss ich auch nicht. Müsste ich noch mal das log anschauen.

Diederik

On 02/09/2013 02:12 PM, marcelloceschia wrote:

probieren

Am Samstag, 9. Februar 2013, 05:08:04 schrieb Diederik de Groot:

Wurde dies das fixen ?

Added pbx_channel_pbx(ast_channel)

Diederik

Index: pbx_impl/ast/ast.c

--- pbx_impl/ast/ast.c (revision 4218)
+++ pbx_impl/ast/ast.c (working copy)
@@ -507,7 +507,7 @@
#else
pbx_channel_setwhentohangup_tv(ast_channel, ast_tvnow());
#endif
-// ast_channel->_state=AST_STATE_DOWN;
+// ast_channel->_state=AST_STATE_DOWN;
ast_queue_hangup(ast_channel);
break;
}
@@ -551,7 +551,7 @@
}
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send
ast_softhangup_nolock (blocker: %s)\n", pbx_channel_name(ast_channel),
pbx_channel_blockproc(ast_channel));
ast_softhangup_nolock(ast_channel, AST_SOFTHANGUP_DEV);

} else if (AST_STATE_UP == pbx_channel_state(ast_channel)) {

} else if (AST_STATE_UP == pbx_channel_state(ast_channel) ||
pbx_channel_pbx(ast_channel)) {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send
ast_queue_hangup\n", pbx_channel_name(ast_channel));
#if ASTERISK_VERSION_NUMBER < 10601
pbx_channel_setwhentohangup_tv(ast_channel, 0);
@@ -561,8 +561,8 @@
ast_queue_hangup(ast_channel);
} else {
sccp_log(DEBUGCAT_CHANNEL) (VERBOSE_PREFIX_3 "%s: send hard
ast_hangup\n", pbx_channel_name(ast_channel));
-// ast_hangup(ast_channel);

ast_queue_hangup(ast_channel);

ast_hangup(ast_channel);
+// ast_queue_hangup(ast_channel);
}

sccp_channel = sccp_channel ? sccp_channel_release(sccp_channel) : NULL;

Reply to this email directly or view it on GitHub:

#35 (comment)

—
Reply to this email directly or view it on GitHub
#35 (comment)..

Reply to this email directly or view it on GitHub:
#35 (comment)

marcelloceschia · 2013-02-10T12:09:18Z

fixed with 72d1754

marcelloceschia closed this as completed Feb 10, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Offhook / OnHook, not hanging up (force ast_hangup) #35

Offhook / OnHook, not hanging up (force ast_hangup) #35

dkgroot commented Feb 8, 2013

marcelloceschia commented Feb 8, 2013

dkgroot commented Feb 8, 2013

marcelloceschia commented Feb 8, 2013

dkgroot commented Feb 8, 2013

dkgroot commented Feb 9, 2013

marcelloceschia commented Feb 9, 2013

Index: pbx_impl/ast/ast.c

dkgroot commented Feb 9, 2013

Index: pbx_impl/ast/ast.c

marcelloceschia commented Feb 9, 2013

Index: pbx_impl/ast/ast.c

marcelloceschia commented Feb 10, 2013

Offhook / OnHook, not hanging up (force ast_hangup) #35

Offhook / OnHook, not hanging up (force ast_hangup) #35

Comments

dkgroot commented Feb 8, 2013

marcelloceschia commented Feb 8, 2013

dkgroot commented Feb 8, 2013

marcelloceschia commented Feb 8, 2013

dkgroot commented Feb 8, 2013

dkgroot commented Feb 9, 2013

Index: pbx_impl/ast/ast.c

marcelloceschia commented Feb 9, 2013

Index: pbx_impl/ast/ast.c

dkgroot commented Feb 9, 2013

Index: pbx_impl/ast/ast.c

marcelloceschia commented Feb 9, 2013

Index: pbx_impl/ast/ast.c

marcelloceschia commented Feb 10, 2013