Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Height is Hardcoded #2

Closed
N0tExisting opened this issue Sep 16, 2021 · 3 comments · Fixed by #3
Closed

Component Height is Hardcoded #2

N0tExisting opened this issue Sep 16, 2021 · 3 comments · Fixed by #3
Labels
good first issue Good for newcomers

Comments

@N0tExisting
Copy link
Contributor

N0tExisting commented Sep 16, 2021

Currently the component height is hardcoded at 200px which is anoying as it is way to high for my purposes and might be to small for other people.

I've made a PR (#3)

@chanced
Copy link
Owner

chanced commented Sep 16, 2021

Ah, the idea was that the default styles would only be applied if class were not provided. However, the assignment of the class isn't there and I need to add a slot.

I didn't realize that svelte doesn't recognize classes assigned to components. I'll switch it over to a slot. The default styles on the component were just meant to be a standin.

In the meantime, use the action.

<div use:filedrop={options} on:filedrop={(e) => {files = e.detail.files}}></div>

@chanced
Copy link
Owner

chanced commented Sep 16, 2021

Switching it to a label is causing an issue with the action, which erroneously assumes the container is a div or some other element that doesn't propagate click to the input.

@chanced chanced reopened this Sep 16, 2021
chanced added a commit that referenced this issue Sep 16, 2021
chanced added a commit that referenced this issue Sep 16, 2021
@chanced chanced added the good first issue Good for newcomers label Sep 16, 2021
@chanced
Copy link
Owner

chanced commented Sep 16, 2021

Thank you for the pr. Your changes have been published.

@chanced chanced closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants