Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "555" area code option #480

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Add "555" area code option #480

merged 1 commit into from
Aug 25, 2020

Conversation

Carter-A
Copy link
Contributor

@Carter-A Carter-A commented Jul 10, 2020 •
edited

Option to specify an example number with an area code of '555' specifically for US.

chance.phone({ country: 'us', exampleNumber: true });
=> '(555) 927-2152'

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.515% when pulling 6813181 on Carter-A:add-examplenumber-option into 24a4b17 on chancejs:master.

@Carter-A Carter-A mentioned this pull request Jul 10, 2020
Open
@Carter-A
Copy link
Contributor Author

Fixes #449

@victorquinn
Copy link
Member

Great update, thanks @Carter-A ! apologies for the delay in review here

@victorquinn victorquinn merged commit b0d0ae6 into chancejs:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorquinn victorquinn victorquinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Carter-A @coveralls @victorquinn