Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "let" identifier #487

Merged
merged 1 commit into from
Aug 25, 2020
Merged

remove "let" identifier #487

merged 1 commit into from
Aug 25, 2020

Conversation

hapood
Copy link
Contributor

@hapood hapood commented Aug 25, 2020

#486 #486 (comment)

remove "let" identifier for compatible with old browsers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.515% when pulling 158e43a on hapood:remove-let-identifier into 24a4b17 on chancejs:master.

@victorquinn
Copy link
Member

oof great catch @hapood ! Thanks

@victorquinn victorquinn merged commit 7eace2e into chancejs:master Aug 25, 2020
@victorquinn
Copy link
Member

published on npm as 1.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorquinn victorquinn victorquinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hapood @coveralls @victorquinn