-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zodiac Symbols #569
Zodiac Symbols #569
Conversation
So I am supportive of this addition and thank you for your work here! My only question is around the list of symbols you have to pick from. You have: ["Ram","Bull","Twins","Crab","Lion","Virgin","Balance","Scorpion","Archer","Goat","Water-Bearer","Fish"] I am no expert on this stuff, but when I do a search, my first hit returns: ["Aries","Taurus","Gemini","Cancer","Leo","Virgo","Libra","Scorpio","Sagittarius","Capricorn","Aquarius","Pisces"] And these are the ones I am more familiar with also. Was there a reason you had the list you did? |
Hi! Thanks for your reply. I decide this nomenclature because i think that is more international (English) but is true that the second list is more recognisable. I change this! |
docs/person/zodiac.md
Outdated
|
||
```js | ||
chance.zodiac(); | ||
=> 'Bull' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the docs to match the common Zodiac signs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey, I forgot. Sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Victor Quinn <mail@victorquinn.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the addition and the fix @seon22break !
* New function to generate random zodyac symbols * Add test to zodiac symbols function * Generate documentation to zodiac symbols * Rename Symbols with a common name * Update documentation with the real signs * Update chance.js Co-authored-by: Victor Quinn <mail@victorquinn.com> --------- Co-authored-by: Victor Quinn <mail@victorquinn.com>
Hello, My name is Jhonatan and I would like to make this small contribution, which allows you to generate a random zodiac sign.
Reason:
Why not?
I like your project and for that reason I would like to contribute with a little bit of code.