Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #204 #572

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix #204 #572

merged 1 commit into from
Feb 14, 2023

Conversation

stefnotch
Copy link
Contributor

As the reporter of #204 points out, this method should modify the current chance object instead of globally changing it.

I think this constitutes a breaking change.

@coveralls
Copy link

Coverage Status

Coverage: 95.558%. Remained the same when pulling 23d76fc on stefnotch:patch-1 into d292eea on chancejs:master.

victorquinn
victorquinn approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@victorquinn victorquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @stefnotch !

@victorquinn victorquinn merged commit 61e49a3 into chancejs:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorquinn victorquinn victorquinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefnotch @coveralls @victorquinn