Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Node version and fixing Github Actions failures #600

Merged
merged 2 commits into from Mar 30, 2024

Conversation

JohnAllenTech
Copy link
Contributor

Pull Request details

  • This is a first step in fixing the broken github action pipelines.
  • Currently there is a duplicate devDependencies key in the package.json. This is causing only 'gulp-uglify-es' to be installed when you run yarn
  • I have also bumped the Node versions to be tested against from 9,10,12 to 12,14,16
  • Bumped the node version for the other pipeline steps to 16

*** This PR may not fix the pipelines but will give me enough information to get a fix together. Currently the pipelines dont even get past the test step ***

Any Breaking changes

  • The opposite. The pipelines are currently broken and this is a first step to a fix

Associated Screenshots

Actions running successfully on my fork
image

@victorquinn victorquinn merged commit bbf3949 into chancejs:master Mar 30, 2024
8 checks passed
@victorquinn
Copy link
Member

Excellent!! Thanks @JohnAllenTech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants