This repository has been archived by the owner on Sep 25, 2021. It is now read-only.
Wrap pinned ListView around a parent View #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the possibility to swipe on the remaining view (the non-list view) and tuck the drawer back in. It also helps when you're trying to pull the drawer out, that it does not grab a list-view item and disregard the drawer animation for a swipe dismiss animation.
|
Might solve issue #29. |
|
Sorry for the delay, I will look into after most of the material stuff is done (this interferes with the drawer that's going to be replaced with a material drawer). |
|
Like with the other pr, this is not relevant anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the possibility to swipe on the remaining view (the non-ListView) and tuck the drawer back in. It also helps when you're trying to pull the drawer out, that it does not grab a list-view item and disregard the drawer animation for a swipe dismiss animation.
This might need more eyes/hands-on before getting merged. It works fine on my side after using it for about 20 minutes.
Any feedback on this is appreciated!