(feat): country code picker style (dialog or modal bottom sheet) sugg… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Gilles-Christ thanks for your support to this package. Can you add description about this feature? Please add some evidence about how this feature work and what the benefits of this feature? Thanks. |
|
The purpose of this new feature is to give users the possibility to choose how they want the selection popup to be displayed. Currently, the selection is done in a dialog box. I have also proposed another option: that it is displayed in a bottom sheet modal. Just like this. 
|
|
Hi @FulbertoDev why you closed this PR? I will merge your changes if you need this? Sorry for late response. |
chandrabezzo
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ested