Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric strings are not correct formatted #13

Closed
pardahlman opened this issue Sep 9, 2015 · 1 comment
Closed

Numeric strings are not correct formatted #13

pardahlman opened this issue Sep 9, 2015 · 1 comment

Comments

@pardahlman
Copy link

There was a bug introduced in pull request #12 (Preformat numeric formatted arguments before passing string to Serilogger) that causes string with more than one numeric argument to be wrongly pre-formatted.

The reason is that we manipulate the string from left-to-right and at the same time uses the char indexes from the matcher in the original template string. If the arg's value has more chars than the formatter itself (which is very likely) we will insert the following matchers based on an old index rather than the new one. The solution is to change the string from right-to-left.

@Jaben
Copy link
Member

Jaben commented Sep 9, 2015

k, merged and will release nuget today.

@Jaben Jaben closed this as completed Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants