HouseKeeping: Moved errors to one place (#201)

* added ExitError and ValidationError to errors package and replaced their usage across repository packages

* added changeset

* extend extendableError package instead of extending JS Error class, for better message logging

* updated changesets

* Maybe it's the cache?

* Try a thing

.changeset/orange-eyes-march.md

@@ -0,0 +1,6 @@
+---
+"@changesets/cli": patch
+"@changesets/config": patch
+---
+
+Updated to use the Error classes from the @changesets/errors package

.changeset/rare-needles-design.md

@@ -0,0 +1,6 @@
+---
+"@changesets/errors": patch
+---
+
+- Added ExitError class and ValidationError class
+- Extend extendable-error in our error classes instead of JS Error class due to better Error messages thrown 

.circleci/config.yml

@@ -8,9 +8,9 @@ jobs:
       - checkout
       - restore_cache:
           keys:
-            - v1-dependencies-{{ checksum "yarn.lock" }}
+            - v2-dependencies-{{ checksum "yarn.lock" }}
             # fallback to using the latest cache if no exact match is found
-            - v1-dependencies-
+            - v2-dependencies-
       - run:
           name: Install
           command: yarn install --pure-lockfile
@@ -43,9 +43,9 @@ jobs:
       - checkout
       - restore_cache:
           keys:
-            - v1-dependencies-{{ checksum "yarn.lock" }}
+            - v2-dependencies-{{ checksum "yarn.lock" }}
             # fallback to using the latest cache if no exact match is found
-            - v1-dependencies-
+            - v2-dependencies-
       - run:
           name: Install
           command: yarn install --pure-lockfile
@@ -61,9 +61,9 @@ jobs:
       - checkout
       - restore_cache:
           keys:
-            - v1-dependencies-{{ checksum "yarn.lock" }}
+            - v2-dependencies-{{ checksum "yarn.lock" }}
             # fallback to using the latest cache if no exact match is found
-            - v1-dependencies-
+            - v2-dependencies-
       - run:
           name: Install
           command: yarn install --pure-lockfile

packages/cli/package.json

@@ -27,6 +27,7 @@
     "@changesets/apply-release-plan": "^0.2.2",
     "@changesets/assemble-release-plan": "^0.2.1",
     "@changesets/config": "^0.2.1",
+    "@changesets/errors": "^0.1.0",
     "@changesets/get-release-plan": "^0.1.3",
     "@changesets/git": "^0.2.3",
     "@changesets/logger": "^0.0.0",

packages/cli/src/commands/publish/index.ts

@@ -1,7 +1,7 @@
 import publishPackages from "./publishPackages";
+import { ExitError } from "@changesets/errors";
 import { error, log, success } from "@changesets/logger";
 import * as git from "@changesets/git";
-import { ExitError } from "../../utils/errors";
 import { Config } from "@changesets/types";
 
 function logReleases(pkgs: Array<{ name: string; newVersion: string }>) {

packages/cli/src/commands/publish/npm-utils.ts

@@ -1,11 +1,11 @@
+import { ExitError } from "@changesets/errors";
 import { error, info, warn } from "@changesets/logger";
 import pLimit from "p-limit";
 import chalk from "chalk";
 import spawn from "spawndamnit";
 import { askQuestion } from "../../utils/cli";
 // @ts-ignore
 import isCI from "is-ci";
-import { ExitError } from "../../utils/errors";
 import { TwoFactorState } from "../../utils/types";
 
 const npmRequestLimit = pLimit(40);

packages/cli/src/index.ts

@@ -1,5 +1,6 @@
 import meow from "meow";
 import { read } from "@changesets/config";
+import { ExitError } from "@changesets/errors";
 import { error } from "@changesets/logger";
 import { Config } from "@changesets/types";
 import fs from "fs-extra";
@@ -11,7 +12,6 @@ import add from "./commands/add";
 import version from "./commands/version";
 import publish from "./commands/publish";
 import status from "./commands/status";
-import { ExitError } from "./utils/errors";
 import { CliOptions } from "./types";
 
 const { input, flags } = meow(

packages/config/package.json

@@ -11,6 +11,7 @@
     "schema.json"
   ],
   "dependencies": {
+    "@changesets/errors": "^0.1.0",
     "@changesets/types": "^0.3.0",
     "fs-extra": "^7.0.1"
   },

packages/config/src/index.ts

@@ -1,5 +1,6 @@
 import * as fs from "fs-extra";
 import path from "path";
+import { ValidationError } from "@changesets/errors";
 import { Config, WrittenConfig, Workspace } from "@changesets/types";
 import packageJson from "../package.json";
 
@@ -122,7 +123,10 @@ export let parse = (
     }
   }
   if (messages.length) {
-    throw new ValidationError(messages);
+    throw new ValidationError(
+      `Some errors occurred when validating the changesets config:\n` +
+        messages.join("\n")
+    );
   }
 
   let config: Config = {
@@ -142,12 +146,3 @@ export let parse = (
 };
 
 export let defaultConfig = parse(defaultWrittenConfig, []);
-
-export class ValidationError extends Error {
-  constructor(messages: Array<string>) {
-    super(
-      `Some errors occurred when validating the changesets config:\n` +
-        messages.join("\n")
-    );
-  }
-}

packages/errors/package.json

@@ -5,5 +5,8 @@
   "main": "dist/errors.cjs.js",
   "module": "dist/errors.esm.js",
   "license": "MIT",
-  "repository": "https://github.com/changesets/changesets/tree/master/packages/errors"
+  "repository": "https://github.com/changesets/changesets/tree/master/packages/errors",
+  "dependencies": {
+    "extendable-error": "^0.1.5"
+  }
 }

packages/errors/src/index.ts

@@ -1,5 +1,19 @@
-export class GitError extends Error {
-  constructor(exitCode: number, message: string) {
-    super(`Error: Git - ${message}, exit code: ${exitCode}`);
+import ExtendableError from "extendable-error";
+
+export class GitError extends ExtendableError {
+  code: number;
+  constructor(code: number, message: string) {
+    super(`${message}, exit code: ${code}`);
+    this.code = code;
+  }
+}
+
+export class ValidationError extends ExtendableError {}
+
+export class ExitError extends ExtendableError {
+  code: number;
+  constructor(code: number) {
+    super(`The process exited with code: ${code}`);
+    this.code = code;
   }
 }

yarn.lock

@@ -2201,6 +2201,11 @@ extend@~3.0.2:
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/extend/-/extend-3.0.2.tgz#f8b1136b4071fbd8eb140aff858b1019ec2915fa"
 
+extendable-error@^0.1.5:
+  version "0.1.5"
+  resolved "https://registry.yarnpkg.com/extendable-error/-/extendable-error-0.1.5.tgz#122308a7097bc89a263b2c4fbf089c78140e3b6d"
+  integrity sha1-EiMIpwl7yJomOyxPvwiceBQOO20=
+
 external-editor@^2.0.4, external-editor@^2.1.0:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/external-editor/-/external-editor-2.2.0.tgz#045511cfd8d133f3846673d1047c154e214ad3d5"