-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor version of peer package causes release of major version #524
Comments
danielkcz
pushed a commit
to mobxjs/mobx
that referenced
this issue
Jan 29, 2021
Thank you, I've applied configuration and hopefully, it will have the desired effect. |
1 task
hasparus
added a commit
to hasparus/TypeChain
that referenced
this issue
Oct 18, 2021
hasparus
added a commit
to dethcrypto/TypeChain
that referenced
this issue
Oct 18, 2021
softdevpro7
added a commit
to softdevpro7/TypeChain
that referenced
this issue
Nov 24, 2022
SuperStar0106
added a commit
to SuperStar0106/Ganache
that referenced
this issue
Jul 1, 2023
3 tasks
jpwilliams
added a commit
to inngest/inngest-js
that referenced
this issue
Dec 12, 2023
## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> We use non-local peer dependencies due to a restriction with the build process of `inngest`. This contributes to changesets bumping peer dependencies for packages that want to reference `inngest` from their wide constraint (e.g. `^3.0.0`) to a narrower one (e.g. `^3.7.1`). I believe we can avoid this using an experimental flag added in changesets/changesets#383. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~~Added a [docs PR](https://github.com/inngest/website) that references this PR~~ N/A - [ ] ~~Added unit/integration tests~~ N/A - [x] Added changesets if applicable ## Related - changesets/changesets#383 - changesets/changesets#524
kyleawayan
added a commit
to czbiohub-sf/czb-ui
that referenced
this issue
Mar 17, 2024
486xtm
pushed a commit
to 486xtm/chain-type
that referenced
this issue
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected Packages
Here is the specific commit generated by
changeset-release
action.mobxjs/mobx@c1f3019
Problem
As you can see, there is a single changeset with
minor
change to the two packages,mobx
andmobx-react-lite
. What's unexpected here is themajor
release ofmobx-react-lite
andmobx-react
in cascade. Even in the changelog, it talks about minor/patch changes so it's rather confusing to the end user.The
mobx-react-lite
depends onmobx
, but only as peerDependency. In my opinion, it doesn't make much sense to forcemajor
in such a case. Minor versions are about adding something new, it's not breaking. What is the reasoning here?Proposed solution
I think it should release a minor version of
mobx-react-lite
as requested.We have fixed it manually for now.
The text was updated successfully, but these errors were encountered: