Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version of peer package causes release of major version #524

Closed
danielkcz opened this issue Jan 27, 2021 · 2 comments
Closed

Minor version of peer package causes release of major version #524

danielkcz opened this issue Jan 27, 2021 · 2 comments

Comments

@danielkcz
Copy link

danielkcz commented Jan 27, 2021

Affected Packages

Here is the specific commit generated by changeset-release action.

mobxjs/mobx@c1f3019

Problem

As you can see, there is a single changeset with minor change to the two packages, mobx and mobx-react-lite. What's unexpected here is the major release of mobx-react-lite and mobx-react in cascade. Even in the changelog, it talks about minor/patch changes so it's rather confusing to the end user.

The mobx-react-lite depends on mobx, but only as peerDependency. In my opinion, it doesn't make much sense to force major in such a case. Minor versions are about adding something new, it's not breaking. What is the reasoning here?

Proposed solution

I think it should release a minor version of mobx-react-lite as requested.

We have fixed it manually for now.

@emmatown
Copy link
Member

This is currently expected behavior. You can change the behavior of Changesets to what you're probably expecting by adding this to your config:

"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
    "onlyUpdatePeerDependentsWhenOutOfRange": true
}

See #185 and #383 for more details

danielkcz pushed a commit to mobxjs/mobx that referenced this issue Jan 29, 2021
@danielkcz
Copy link
Author

Thank you, I've applied configuration and hopefully, it will have the desired effect.

jpwilliams added a commit to inngest/inngest-js that referenced this issue Dec 12, 2023
## Summary
<!-- Succinctly describe your change, providing context, what you've
changed, and why. -->

We use non-local peer dependencies due to a restriction with the build
process of `inngest`.

This contributes to changesets bumping peer dependencies for packages
that want to reference `inngest` from their wide constraint (e.g.
`^3.0.0`) to a narrower one (e.g. `^3.7.1`).

I believe we can avoid this using an experimental flag added in
changesets/changesets#383.

## Checklist
<!-- Tick these items off as you progress. -->
<!-- If an item isn't applicable, ideally please strikeout the item by
wrapping it in "~~"" and suffix it with "N/A My reason for skipping
this." -->
<!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" -->

- [ ] ~~Added a [docs PR](https://github.com/inngest/website) that
references this PR~~ N/A
- [ ] ~~Added unit/integration tests~~ N/A
- [x] Added changesets if applicable

## Related

- changesets/changesets#383
- changesets/changesets#524
kyleawayan added a commit to czbiohub-sf/czb-ui that referenced this issue Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants