Remove dep on bolt and fix 2fa stuff

[emmatown]

No description provided.

[changeset-bot]

🦋 Changeset is good to go

Latest commit: 5d03edd

We got this.

Not sure what this means? Click here to learn what changesets are.

[codecov-io]

Codecov Report

Merging #106 into master will decrease coverage by 5.59%.
The diff coverage is 7.92%.

@@            Coverage Diff            @@
##           master     #106     +/-   ##
=========================================
- Coverage   82.66%   77.07%   -5.6%     
=========================================
  Files          31       33      +2     
  Lines         819      881     +62     
  Branches      144      160     +16     
=========================================
+ Hits          677      679      +2     
- Misses        131      193     +62     
+ Partials       11        9      -2

Impacted Files	Coverage Δ
packages/cli/src/utils/logger.ts	12.5% <ø> (ø)	⬆️
.../src/utils/bolt-replacements/getDependencyGraph.ts	90.62% <ø> (ø)	⬆️
packages/get-workspaces/src/index.ts	96.42% <ø> (ø)	⬆️
packages/cli/src/utils/errors.ts	0% <0%> (ø)
...ckages/cli/src/commands/release/publishPackages.ts	0% <0%> (ø)
packages/cli/src/commands/bump/index.js	96.82% <100%> (+0.05%)	⬆️
packages/cli/src/commands/release/index.ts	77.27% <37.5%> (ø)
packages/cli/src/commands/release/npm-utils.ts	6.89% <6.89%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55fa3f...5d03edd. Read the comment docs.

[Noviny]

Code for this looks good (aside from removing bolt dependency) - manual testing showed a weirdness. Was running publish in: https://github.com/Noviny/test-changeset

Basically, it asked me for 2fa, then immediately asked me again, then return publishing successes. Tested this twice and got the same results.

Aside, added a mental backlog task to move this repo into changesets, and the packages into the changesets scope, so anyone with scope access can use these packages to test whatever.

[Noviny]

I couldn't find any instance where we are using bolt in our packages - can we remove the dependency from here entirely?

[Noviny]

I think these checks may still make sense, but it's more 'release plan will create invalid state' - We may want to lean on bolt-check to do this, and filter the errors we get?

[Noviny]

Bump is the thing most impacted by my rewrite, so I wouldn't worry about fixing these now, I'll be doing a pass over the messaging around running bumps as part of that.

[emmatown]

Yep, I wrote a comment about changing the error message to something like that above, this comment was purely about accessing internalDeps[depName] because internalDeps is an array and depName is a string so the result will always be undefined.

changesets/packages/cli/src/commands/bump/index.js

Lines 139 to 141 in 5d03edd

	// TODO: this error message was copied directly from bolt
	// it seems wrong, shouldn't this case be covered by dependents stuff
	// and this should be something like "this should never happen, please open an issue because there's probably a bug in changesets"