Changelog packages #170
Changelog packages #170
Conversation
…try file with changelog-github
🦋 Changeset is good to goLatest commit: b650b76 We got this. Not sure what this means? Click here to learn what changesets are. |
| import { config } from "dotenv"; | ||
| import { getInfo } from "@changesets/get-github-info"; | ||
|
|
||
| config(); |
There was a problem hiding this comment.
I have mixed feelings about this. Is adding dotenv an opinion that we should have?
There was a problem hiding this comment.
Same - I don't have strong opinions. I think this is an easy path forward so happy to Just Merge for now. What do we do in other projects?
There was a problem hiding this comment.
We use it in other places so I'm happy to Just Merge
| @@ -1,7 +1,8 @@ | |||
| // @ts-ignore | |||
| import fetch from "node-fetch"; | |||
There was a problem hiding this comment.
I was lazy about typing this file because IMO the external API is the important part to be typed here. Typing the internals would just be painful and unhelpful.
| import { config } from "dotenv"; | ||
| import { getInfo } from "@changesets/get-github-info"; | ||
|
|
||
| config(); |
There was a problem hiding this comment.
Same - I don't have strong opinions. I think this is an easy path forward so happy to Just Merge for now. What do we do in other projects?
|
(happy if you want to merge this) |
No description provided.