-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal logging package and a test-utils package to help them #182
Conversation
🦋 Changeset is good to goLatest commit: 86892f9 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adfbb84
to
36a6eb9
Compare
36a6eb9
to
36894f1
Compare
4221ac6
to
3f12cdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!!
|
||
**success**: Use `success` to assert to users that their instructions have completed succesfully. | ||
|
||
**warn**: Use `warn` to print warning messages, something that user could action on now or later without much impact of their work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this, talking about it when to use them is great!
Also: needs a changeset/changesets |
… uses the new logging system internally
Co-Authored-By: Mitchell Hamilton <mitchell@hamil.town>
Co-Authored-By: Mitchell Hamilton <mitchell@hamil.town>
Co-Authored-By: Mitchell Hamilton <mitchell@hamil.town>
Co-Authored-By: Mitchell Hamilton <mitchell@hamil.town>
Co-Authored-By: Mitchell Hamilton <mitchell@hamil.town>
The commit history is not pretty at the moment. I feel some of the messages can be improved and some commits be squashed. I am spend time in fixing the messages. If we do a merge. Else we can update message on squash and commit. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you split the changeset into two, one for logger and test-utils that says initial release and another for cli that says it's using @changesets/logger? Apart from that, LGTM. re commits: we'll squash merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Hey @mitchellhamilton, Thanks for reviewing the PR. Should we merge it? |
I was going to wait for @Noviny to ✅ it but it's not really a change that's likely to cause problems so let's merge it. |
re: #142
Adding two packages, @changesets/logger and @changesets/test-utils.
@changesets/logger
Log messages to stdout.
Usage:
@changesets/test-utils
All test utilities, at the moment only one - temporarilySilenceLogs, it will silence all logs done in the changesets file. **It will not highjack console, therefore console.*(xxx) will still. Which in my perspective is needed to not accidentally silence the error message.
This PR is in progress, but inputs at any step are welcome.