Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update ranges set to */x/X when versioning #205

Merged
merged 4 commits into from
Oct 26, 2019

Conversation

emmatown
Copy link
Member

This means we won't break Manypkg's new "make internal dev deps '*'" rule.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2019

🦋 Changeset is good to go

Latest commit: 1c3aef8

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmatown emmatown requested a review from Noviny October 26, 2019 08:40
@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #205 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #205      +/-   ##
=========================================
+ Coverage   76.35%   76.4%   +0.04%     
=========================================
  Files          41      41              
  Lines        1049    1051       +2     
  Branches      228     223       -5     
=========================================
+ Hits          801     803       +2     
  Misses        244     244              
  Partials        4       4
Impacted Files Coverage Δ
packages/apply-release-plan/src/version-package.ts 100% <100%> (ø) ⬆️
packages/apply-release-plan/src/index.ts 86.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003db6b...1c3aef8. Read the comment docs.

@emmatown emmatown merged commit da11ab8 into master Oct 26, 2019
@emmatown emmatown deleted the do-not-update-ranges-set-to-match-all-versions branch October 26, 2019 09:12
@github-actions github-actions bot mentioned this pull request Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants