Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip OTP check during isCI #209

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

ryanbraganza
Copy link
Contributor

During CI, a token shouldn't be required.

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2019

🦋 Changeset is good to go

Latest commit: db29e78

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #209 into master will increase coverage by 2.74%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   77.19%   79.93%   +2.74%     
==========================================
  Files          44       44              
  Lines        1175     1176       +1     
  Branches      262      259       -3     
==========================================
+ Hits          907      940      +33     
+ Misses        264      230      -34     
- Partials        4        6       +2
Impacted Files Coverage Δ
...ckages/cli/src/commands/publish/publishPackages.ts 73.33% <0%> (+73.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a48db...db29e78. Read the comment docs.

@Noviny
Copy link
Collaborator

Noviny commented Nov 3, 2019

I'm happy with this change. I wouldn't mind stopping the codecov from failing, and this needs a conflict resolved, but happy to merge and release this to unblock you without going too deep on ensuring coverage up.

@ryanbraganza
Copy link
Contributor Author

d'oh, I did the classic "fetch origin" thing, but my origin is set to my fork. I'll fix the conflicts.

@Noviny Noviny merged commit a0b5dba into changesets:master Nov 4, 2019
@github-actions github-actions bot mentioned this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants