-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new @changesets/write package to separate writing changesets #292
Conversation
🦋 Changeset is good to goLatest commit: dcb09e6 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=====================================
Coverage 80% 80%
=====================================
Files 45 45
Lines 1220 1220
Branches 280 284 +4
=====================================
Hits 976 976
Misses 233 233
Partials 11 11
Continue to review full report at Codecov.
|
25c4399
to
6bae2b2
Compare
6bae2b2
to
c752bb2
Compare
Hey! Thanks for this. We initially didn't do this because writing a changeset is simple enough that reimplementing it isn't really a cost, and having it as a library implies it's doing something fancier than it is. What's the reason for wanting this as a package as opposed to just using the code yourself? |
PR otherwise looks fine, so happy to merge + release |
Makes sense. I guess since we already have the
We need a way to programmatically create a changeset (our use case is to integrate the renovate bot into our monorepo, and there needs to be a way to generate a changeset for the diff that the renovate bot creates). It seemed odd that we had to duplicate the same logic that |
This PR adds a new package
@changesets/write
which does the inverse of@changesets/parse
.It basically just extracts the
writeChangesets
function used in@changesets/cli
so it can be re-used.