fix: pnpm detection in projects that use a shared lockfile #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 67a600c We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 79.62% 79.84% +0.22%
==========================================
Files 40 40
Lines 1065 1062 -3
Branches 239 237 -2
==========================================
Hits 848 848
+ Misses 207 204 -3
Partials 10 10
Continue to review full report at Codecov.
|
zkochan
commented
Apr 17, 2020
| } | ||
| const pm = await preferredPM(cwd); | ||
| if (!pm) return "npm"; | ||
| return pm.name === "pnpm" ? "pnpm" : "npm"; |
There was a problem hiding this comment.
preferred-pm also detects Yarn properly. But this function was only returning npm or pnpm, so probably should stay that way.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.