-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#309 #336
Issue#309 #336
Conversation
🦋 Changeset is good to goLatest commit: 54d05fb We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 79.84% 79.84%
=======================================
Files 40 40
Lines 1062 1062
Branches 237 237
=======================================
Hits 848 848
Misses 204 204
Partials 10 10
Continue to review full report at Codecov.
|
I just want to add that this doesn't need a new test because one of the tests already fail on Windows due to the issue. |
Co-Authored-By: Zoltan Kochan <zkochan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
"changeset add" doesn't show changed packages because of '/' vs '\' path issue