Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency release lines being output when they were skipped via the updateInternalDependencies config option #361

Merged
merged 1 commit into from
May 12, 2020

Conversation

Blasz
Copy link
Contributor

@Blasz Blasz commented May 11, 2020

No description provided.

…the updateInternalDependencies config option
@Blasz Blasz requested a review from Noviny May 11, 2020 07:22
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2020

🦋 Changeset is good to go

Latest commit: 006dcd5

We got this.

This PR includes changesets to release 2 packages
Name Type
@changesets/apply-release-plan Patch
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #361 into master will increase coverage by 0.12%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   79.96%   80.09%   +0.12%     
==========================================
  Files          40       41       +1     
  Lines        1083     1085       +2     
  Branches      250      249       -1     
==========================================
+ Hits          866      869       +3     
  Misses        207      207              
+ Partials       10        9       -1     
Impacted Files Coverage Δ
packages/apply-release-plan/src/version-package.ts 100.00% <ø> (+3.70%) ⬆️
packages/apply-release-plan/src/utils.ts 85.71% <85.71%> (ø)
...ages/apply-release-plan/src/get-changelog-entry.ts 100.00% <100.00%> (+4.54%) ⬆️
packages/apply-release-plan/src/index.ts 92.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13406e9...006dcd5. Read the comment docs.

@Noviny Noviny merged commit 52a88ce into master May 12, 2020
@Noviny Noviny deleted the fix-update-internal-dependencies branch May 12, 2020 00:57
@github-actions github-actions bot mentioned this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants