feat: allow publishing private packages #569
Conversation
|
Hooray! All contributors have signed the CLA. |
🦋 Changeset detectedLatest commit: 2147633 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This patch maintains our changesets installation up to date with the change proposed in changesets/changesets#569
gakonst
force-pushed
the
feat/publish-private-packages
branch
from
438484f
to
2147633
Compare
|
Hi @mitchellhamilton is there any feedback for this PR? |
| log("New tag: ", tag); | ||
| await git.tag(tag, cwd); | ||
| } else { | ||
| log("Skipping existing tag: ", tag); |
There was a problem hiding this comment.
When this branch could be chosen? Tag conflict seems like a problem and not something that should be silently silenced
| @@ -34,6 +34,13 @@ async function tag(tagStr: string, cwd: string) { | |||
| return gitCmd.code === 0; | |||
| } | |||
|
|
|||
| async function tagExists(tagStr: string) { | |||
There was a problem hiding this comment.
this is a new export from the @changesets/git package so a changeset should be created to account for that
This patch maintains our changesets installation up to date with the change proposed in changesets/changesets#569
|
This change would be super useful for us - we want to use changesets to manage release notes and versioning for node packages that are not published to npm. If |
|
Hey @mitchellhamilton @Andarist just giving this a friendly bump, i'm just setting up another project and would love to move away from my patch-package approach :) |
|
Just playing with this, it still checks NPM for the existence of the private packages through. With my PR for public NPM packages I used that status, otherwise I used tags. I think it should clearly separate the logic for each. |
|
This got superseded by #662 |
Supersedes #420.
We get all packages (instead of just the public ones) and we only publish the public ones, while returning
published = truefor everything else, so that they can be used in the tagging step after publishing.Context: #399, #478 (comment)
cc @mitchellhamilton